New Feature: Allow passing phase to sample generation#481
New Feature: Allow passing phase to sample generation#481CSSFrancis wants to merge 2 commits intopyxem:developfrom
Conversation
|
Thanks for this, @CSSFrancis. But, I suggest to wait with this until after the v0.12.0 release. As @harripj asked and I agreed with in #480, we should allow this all places where it makes sense. Also, I'm not sure of the best implementation. Should we allow passing a |
|
@hakonanes That's fair! We can just make the 0.12.0 release and then figure this out later if you think that is a good idea. I was just trying to follow what was there previously. We should probably have one parameter that checks if it is a point group, a space group or phase or something that checks to make sure only one is defined. |
Description of the change
Adds #480 for sampling generators.
Progress of the PR
Minimal example of the bug fix or new feature
For reviewers
__init__.py.section in
CHANGELOG.rst.__credits__inorix/__init__.pyand in.zenodo.json.