Replace use of 'type' where 'object' is intended. Closes #209#210
Open
Stokestack wants to merge 1 commit intoqmlbook:mainfrom
Open
Replace use of 'type' where 'object' is intended. Closes #209#210Stokestack wants to merge 1 commit intoqmlbook:mainfrom
Stokestack wants to merge 1 commit intoqmlbook:mainfrom
Conversation
Author
|
There's supposed to be a way to link this to an issue, but there is no such option (or any options) on the right under "Development." This issue is #209 |
Stokestack
changed the title
Author
|
Are PRs ever getting integrated? Is this project still alive? |
MartinDelille
approved these changes
Oct 9, 2023
|
Last merged PR was indeed quite a long time ago... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are quite a few places where the word "type" is used but "object" is meant. This is not only confusing but significantly incorrect in a couple of places. For example, in one place it said that an ID is an alias for a type (rather than an object), and in another it refers to a parent type rather than a parent object.