Don't reapply norms already applied in the same session#53
Open
tobias wants to merge 1 commit intoqtrfeast:masterfrom
Open
Don't reapply norms already applied in the same session#53tobias wants to merge 1 commit intoqtrfeast:masterfrom
tobias wants to merge 1 commit intoqtrfeast:masterfrom
Conversation
This makes norm application faster by not repeatedly applying the same norms. This can be slow when there are many norms with a deep dependency tree. In order to implement this, the structure was changed significantly: - the reduction accumulator is no longer passed all the way down to `reduce-txes` - error-handling is now top-level
tobias
commented
May 18, 2023
Comment on lines
+239
to
+252
| acc (-> acc | ||
| (update :results concat (:results requires-results)) | ||
| (update :applied-norms into (:applied-norms requires-results)))] | ||
| (if (contains? (:applied-norms acc) norm-name) | ||
| acc | ||
| (try | ||
| (-> acc | ||
| (update :results concat | ||
| (if first-time-only | ||
| (handle-first-time-only-norm conn norm-attr norm-map norm-name | ||
| sync-schema-timeout tx-instant) | ||
| (handle-mutable-norm conn norm-attr norm-map norm-name | ||
| sync-schema-timeout tx-instant))) | ||
| (update :applied-norms conj norm-name)) |
Author
There was a problem hiding this comment.
This is the heart of the change; we keep a set of norms we have processed in the current session, and skip processing for a norm if we see it again in the dependency tree.
It may be better to topologically sort the dependency tree and walk it once, but that would have been a bigger change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes norm application faster by not repeatedly applying the same
norms. This can be slow when there are many norms with a deep dependency
tree.
In order to implement this, the structure was changed significantly:
reduce-txesWe are currently using a fork of conformity at Shortcut that includes this change because we have a fairly complicated norm dependency tree. Before this change, a full conformity run against a fresh db would take 90 seconds. With this change, it now takes 1.8 seconds.
I'm offering it upstream in case it is useful for others.