Added Multimedia Video and Display GStreamer test scripts by nitinn22 · Pull Request #290 · qualcomm-linux/qcom-linux-testkit

nitinn22 · 2026-02-13T12:40:38Z

The scripts support GStreamer level validation for video and display,

Video: H.264/H.265/VP9 encode/decode with V4L2
Display: Wayland compositor validation

More info in their corresponding readme files.

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

…sing Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand

Please move the generic helpers currently defined in Video_Encode_Decode/run.sh into Runner/utils/lib_gstreamer.sh so other GST tests can reuse them:
get_resolution_params() ->gstreamer_resolution_to_wh()
get_encoder_element() / get_decoder_element() -> gstreamer_v4l2_{encoder,decoder}_for_codec()
get_file_extension() -> gstreamer_container_ext_for_codec() (or similar)
Extract pipeline string creation into library builders:
gstreamer_build_v4l2_encode_pipeline()
gstreamer_build_v4l2_decode_pipeline()
Move bitrate selection + file-size helper into lib (gstreamer_bitrate_for_resolution, gstreamer_file_size_bytes) to avoid re-implementations.

Keep .res emission + summary logic in run.sh. library functions should not write results directly.

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/Waylandsink_Playback.yaml

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/Waylandsink_Playback.yaml

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

Runner/suites/Multimedia/GSTreamer/Video/Video_Encode_Decode/run.sh

…r V4L2 video helper functions from Video_Encode_Decode test to shared lib_gstreamer.sh for code reuse across all GStreamer tests Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand · 2026-02-15T13:10:14Z

@nitinn22 Kindly close the comments where you've already addressed previous review feedback, so I can focus on the remaining ones. Also, please rebase your work on top of the main branch. Also Updated SPDX license identifiers from BSD-3-Clause-Clear to BSD-3-Clause per legal request.

smuppand

README inconsistency (Waylandsink): help text says default test is “for 10s” but script default duration resolves to 30s. Update README/help examples.

README mismatch (Video): documentation lists encoded outputs like .h264/.h265, but the pipeline uses mp4mux and outputs .mp4. Update README to match reality.

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/Waylandsink_Playback.yaml

Runner/suites/Multimedia/GSTreamer/Video/Video_Encode_Decode/run.sh

…video scripts based on review comments Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

…l request Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

Runner/suites/Multimedia/GSTreamer/Video/Video_Encode_Decode/run.sh

Runner/utils/lib_gstreamer.sh

…omments Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand

Better to address few before merge (non-blocking but important)

Runner/utils/lib_gstreamer.sh

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

…received Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Signed-off-by: nitinn22 <nitinn@qti.qualcomm.com>

smuppand · 2026-02-24T15:20:43Z

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

+while [ "$SEARCH" != "/" ]; do
+  if [ -f "$SEARCH/init_env" ]; then
+    INIT_ENV="$SEARCH/init_env"
+    break


If init_env is missing, .res stays empty.

smuppand · 2026-02-24T15:27:38Z

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh

+duration="${VIDEO_DURATION:-${RUNTIMESEC:-30}}"
+pattern="${VIDEO_PATTERN:-smpte}"
+width="${VIDEO_WIDTH:-1920}"
+height="${VIDEO_HEIGHT:-1080}"


You validate VIDEO_DURATION, RUNTIMESEC, VIDEO_FRAMERATE, debug level — but not VIDEO_WIDTH / VIDEO_HEIGHT.
If someone passes VIDEO_WIDTH=1920x1080 (or any non-numeric), your basic sanity block can hit "integer expression expected"/ undefined behavior depending on the shell

smuppand · 2026-02-24T15:32:58Z

Runner/suites/Multimedia/GSTreamer/Video/Video_Encode_Decode/run.sh

+SEARCH="$SCRIPT_DIR"
+while [ "$SEARCH" != "/" ]; do
+  if [ -f "$SEARCH/init_env" ]; then
+    INIT_ENV="$SEARCH/init_env"


Same here as well..

smuppand · 2026-02-24T15:34:37Z

Runner/suites/Multimedia/GSTreamer/Video/Video_Encode_Decode/run.sh

+# Validate environment variables if set
+# Validate numeric parameters
+for param in VIDEO_DURATION RUNTIMESEC VIDEO_FRAMERATE VIDEO_GST_DEBUG GST_DEBUG_LEVEL; do
+  val="${!param:-}"


Is a bashism, remove the loop and validate each env var explicitly or use a posix safe eval.

smuppand · 2026-02-24T15:35:55Z

Runner/suites/Multimedia/GSTreamer/Video/Video_Encode_Decode/run.sh

+        echo "$TESTNAME SKIP" >"$RES_FILE"
+        exit 0
+      fi
+      if [ -n "$2" ] && ! is_u32 "$2"; then


u32 isn't guarenteed.

smuppand · 2026-02-24T15:37:04Z

Runner/suites/Multimedia/GSTreamer/Video/Video_Encode_Decode/run.sh

+  encoder=$(gstreamer_v4l2_encoder_for_codec "$codec")
+  if [ -z "$encoder" ]; then
+    log_warn "Encoder not available for $codec"
+    skip_count=$((skip_count + 1))


remove the skip_count++ increments from the VP9 pre-step and let the actual decode test be the single source of skip accounting.
Specifically remove these (3 places):
when IVF not found after download attempt
when missing ivfparse/muxer
when conversion fails and you rm files
That keeps actual_total = pass+fail+skip aligned with executed tests.

…g as per repo standards Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

…ttern Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

…ner/utils/send-to-lava.sh Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

…yback.yaml Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

…unt logic for vp9 Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

…bm clip removed ivf dep, updated lib gstreamer with addon local clip function for vp9 test Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

…pendencies Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand

LGTM

nitinn22 added 2 commits February 13, 2026 18:07

Added Multimedia Video and Display GStreamer test scripts

e08522e

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Fix: make run.sh executables for both video and display scripts

79fd143

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

bhargav0610 requested review from smuppand and vnarapar February 13, 2026 13:08

Updated lib gstreamer sh utils file to support logs based post proces…

93f6153

…sing Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand requested changes Feb 14, 2026

View reviewed changes

Extract V4L2 video helpers to reusable library. Move generic GStreame…

bd8ef68

…r V4L2 video helper functions from Video_Encode_Decode test to shared lib_gstreamer.sh for code reuse across all GStreamer tests Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand requested changes Feb 15, 2026

View reviewed changes

nitinn22 added 2 commits February 15, 2026 23:12

rebased lib_gstreamer.sh and added changes, modified the display and …

55d63f0

…video scripts based on review comments Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Added license identifier for all 3 shell files: BSD-3-Clause per lega…

77b5d42

…l request Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand requested changes Feb 16, 2026

View reviewed changes

Updated wayland, video and lib gstreamer sh scripts based on review c…

01767d2

…omments Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand requested changes Feb 21, 2026

View reviewed changes

Runner/utils/lib_gstreamer.sh Show resolved Hide resolved

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh Outdated Show resolved Hide resolved

Runner/suites/Multimedia/GSTreamer/Display/Waylandsink_Playback/run.sh Outdated Show resolved Hide resolved

nitinn22 added 2 commits February 24, 2026 14:00

Made changes to handle display and video sh scripts per new comments …

8b2f32c

…received Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Merge branch 'main' into feature/gstchange

2b50999

Signed-off-by: nitinn22 <nitinn@qti.qualcomm.com>

smuppand requested changes Feb 24, 2026

View reviewed changes

nitinn22 added 11 commits February 24, 2026 22:01

Made changes to handle display and video sh scripts to follow sourcin…

bf17e92

…g as per repo standards Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

replaced the is_u32 function call with the same numeric validation pa…

d6f55b1

…ttern Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Fixed LAVA results reporting by using absolute path: ${REPO_PATH}/Run…

4718eb2

…ner/utils/send-to-lava.sh Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Fixed YAML syntax by properly indenting the block scalar section

d2a55e9

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

updated both YAML files to match the working structure from Audio_Pla…

c0b7680

…yback.yaml Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Simplified the yaml files added consistent indentation

8786de3

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Updated emit results logic in video run.sh file also modified skip co…

8f8396a

…unt logic for vp9 Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Skip count removed for vp9 encode as its unsupported

11b76a2

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Removed noisy yamls, updated sh script to handle vp9 download only we…

087d2d7

…bm clip removed ivf dep, updated lib gstreamer with addon local clip function for vp9 test Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Vp9 decode supporting clip url modified and removed ivf conversion de…

78acf3c

…pendencies Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

Updated video sh script to emit results including failure count info

72946d2

Signed-off-by: Nitin Nakka <nitinn@qti.qualcomm.com>

smuppand requested a review from abbajaj806 February 26, 2026 18:22

smuppand approved these changes Feb 27, 2026

View reviewed changes

smuppand merged commit ee7c271 into qualcomm-linux:main Feb 27, 2026
12 checks passed

Conversation

nitinn22 commented Feb 13, 2026

Uh oh!

smuppand left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smuppand commented Feb 15, 2026

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smuppand Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

smuppand Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

smuppand Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

smuppand Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

smuppand Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

smuppand Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

smuppand left a comment •

edited

Loading