Feat: Implement dynamic scaling factor with damping#80
Open
quantumgizmos wants to merge 1 commit intomainfrom
Open
Feat: Implement dynamic scaling factor with damping#80quantumgizmos wants to merge 1 commit intomainfrom
quantumgizmos wants to merge 1 commit intomainfrom
Conversation
…tor handling in bp.hpp; add empty test file for bp_serial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the LDPC project, focusing on versioning, test adjustments, and improvements to the behavior of the
ms_scaling_factorparameter in the belief propagation algorithm. The most important changes include a version bump, modifications to test cases, and updates to the scaling factor logic in the C++ implementation.Versioning:
2.3.6to2.3.7inpyproject.toml.Scaling factor logic:
ms_scaling_factorinsrc_cpp/bp.hppto handle negative values. Negative values now apply a damping factor using the absolute value of the scaling factor, improving flexibility in the belief propagation algorithm. [1] [2]Test adjustments:
ms_scaling_factorparameter in two test cases (test_400_16_6_hgp) inpython_test/test_qcodes.pyfrom0to-1to reflect new behavior for negative scaling factors. [1] [2]