Open
Conversation
…e minimum sum scaling factor handling
…orresponding tests
…and update documentation
…test_400_16_6_hgp
…, update tests and documentation
… and converge parameters
…amic scaling factor test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a dynamic scaling factor damping mechanism in the minimum-sum (MS) belief propagation (BP) decoder and its Python/C++ interfaces. The main goal is to allow the MS scaling factor to evolve dynamically during decoding, which can improve convergence and performance. The changes are thoroughly tested with new unit tests and are integrated into several decoder classes.
Key changes:
Core C++ Implementation
dynamic_scaling_factor_dampingandms_converge_valueparameters to theBpDecoderclass, and implemented logic inset_up_ms_scaling_factors()to initialize the per-iteration scaling factor vector based on these parameters. The MS update now uses the correct scaling factor for each iteration. (src_cpp/bp.hpp) [1] [2] [3] [4] [5]Python Interface & Typings
BeliefFindDecoderto accept and document the newdynamic_scaling_factor_dampingandms_converge_valueparameters, ensuring consistency between the C++ and Python APIs. (src_python/ldpc/belief_find_decoder/_belief_find_decoder.pyx,src_python/ldpc/belief_find_decoder/__init__.pyi) [1] [2]Testing
cpp_test/TestBPDecoder.cpp,python_test/test_bp_dynamic_scaling_factor.py) [1] [2]Example Usage and Integration
python_test/test_qcodes.py,python_test/test_bplsd.py) [1] [2] [3] [4]Miscellaneous
2.3.9to reflect these new features. (pyproject.toml)These changes make the MS BP decoder more flexible and tunable, and ensure robust testing and documentation across both C++ and Python interfaces.