Feature/filter #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staicy-S
reviewed
Jan 26, 2024
Collaborator
Staicy-S
left a comment
Staicy-S
left a comment
There was a problem hiding this comment.
-
- Styling sieht gut aus
-
- Für das Button highlighting brauchst du eigentlich einen state 🤭 da musst du nochmal ran
Collaborator
|
sehr gute Lösung - prima |
Staicy-S
reviewed
Jan 26, 2024
Collaborator
Staicy-S
left a comment
Staicy-S
left a comment
There was a problem hiding this comment.
- die buttons solltest du noch nicht in einer externen componente einbauen, da ihr noch kein state uplifting gelernt habt und du wahrscheinlich da nicht weiter kommen wirst 🙈
src/components/ButtonBar.jsx
Outdated
| import { useState } from "react"; | ||
|
|
||
| export function ButtonBar() { | ||
| let [btnHiglight, setBtnHighLight] = useState(""); |
Collaborator
There was a problem hiding this comment.
die useStates definiert man immer mit const !
src/components/ButtonBar.jsx
Outdated
| } | ||
| return ( | ||
| <> | ||
| <div className={styles["btn-comtainer"]}> |
Collaborator
There was a problem hiding this comment.
container meintest du wahrscheinlich (nicht comtainer)
Collaborator
|
Die Ich würde dir aber für heute empfehlen, keine Komponente Wenn du dir das Thema "State-Up-Lifting" schon mal anschauen möchtest => https://react.dev/learn/sharing-state-between-components Sonst schreibe erst mal deinen Code in die |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add button list