fix: remove tar.gz file after installing so it does not leave git repo dirty#2
Open
jumski wants to merge 1 commit intoquarylabs:mainfrom
Open
fix: remove tar.gz file after installing so it does not leave git repo dirty#2jumski wants to merge 1 commit intoquarylabs:mainfrom
jumski wants to merge 1 commit intoquarylabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was debugging the release build for my project today because it failed to release after i added the sqruff into the workflow.
The issue was that the sqruff install action was not removing tgz file after unpacking.
I implemented the absolute minimal change ("rm sqruff.tgz"), but I think the more clean solution would be to wget into /tmp - this way it would not fail in case a future release for sqruff will contain some other files on top of sqruff binary.