Open
Conversation
Add support for pgvector types (VECTOR, HALFVEC, SPARSEVEC) as a configurable extension for the PostgreSQL dialect. This fixes the indentation bug when using VECTOR type in CREATE TABLE statements. Configuration: ```ini [sqruff] dialect = postgres [sqruff:postgres] extensions = pgvector ``` This adds: - `apply_pgvector_extension` function in postgres.rs that adds pgvector types with optional dimension parameters (e.g., VECTOR(3072)) - Configuration support in FluffConfig to read postgres-specific extensions - Feature flag propagation from sqruff-lib to sqruff-lib-dialects Fixes #2070
Benchmark for af90c29Click to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for pgvector types (VECTOR, HALFVEC, SPARSEVEC) as a configurable extension for the PostgreSQL dialect. This fixes the indentation bug when using VECTOR type in CREATE TABLE statements.
Configuration:
This adds:
apply_pgvector_extensionfunction in postgres.rs that adds pgvector types with optional dimension parameters (e.g., VECTOR(3072))Fixes #2070