feat: add parser validation for fixed SQL in rule fixtures#2121
Open
feat: add parser validation for fixed SQL in rule fixtures#2121
Conversation
Benchmark for ae4bac3Click to view benchmark
|
Add validation that all fix_str values in rule fixtures can be parsed
without errors. This ensures that rule fixes produce valid SQL that the
parser can process.
The validation:
- Parses the fix_str after a fix is applied
- Checks for any Unparsable segments in the parse tree
- Fails the test if unparsable sections are found
Skips validation for cases with Jinja template syntax ({{ or {%)
when the jinja templater is not configured, as these would be
unparsable anyway without template expansion.
benfdking
force-pushed
the
claude/add-sqruff-parser-validation-TnXdM
branch
from
e5685c2 to
38ffd57
Compare
Benchmark for 2cbde0dClick to view benchmark
|
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation that all fix_str values in rule fixtures can be parsed
without errors. This ensures that rule fixes produce valid SQL that the
parser can process.
The validation:
Skips validation for cases with Jinja template syntax ({{ or {%)
when the jinja templater is not configured, as these would be
unparsable anyway without template expansion.