fix: support unquoted Unicode identifiers in ANSI and Postgres dialects#2282
Open
fix: support unquoted Unicode identifiers in ANSI and Postgres dialects#2282
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Benchmark for cdcdbfeClick to view benchmark
|
benfdking
force-pushed
the
fix/unicode-identifiers
branch
from
cefa1ee to
f87ada2
Compare
Benchmark for f9743faClick to view benchmark
|
Replace ASCII-only character classes ([a-zA-Z0-9_]) with Unicode-aware
classes (\p{L}, \p{N}) in lexer word patterns and parser identifier
regexes for the ANSI and Postgres dialects. This fixes panics when
linting SQL with unquoted multibyte identifiers (e.g. Japanese, French,
German characters).
Closes #2067
benfdking
force-pushed
the
fix/unicode-identifiers
branch
from
f87ada2 to
ce4af88
Compare
Benchmark for aaaa31fClick to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[a-zA-Z0-9_]) with Unicode-aware classes (\p{L},\p{N}) in lexer word patterns and parser identifier regexes for the ANSI and Postgres dialects日本語,café,über)Closes #2067