Skip to content

Conversation

@jouvin
Copy link
Contributor

@jouvin jouvin commented Nov 13, 2024

Templates for Antelope are the first to implement the new repository layout (#62). Fixes #1.

@jouvin jouvin requested a review from jrha November 13, 2024 17:36
@jouvin jouvin marked this pull request as draft November 13, 2024 20:37
@jrha jrha added this to the 25.next milestone Nov 13, 2024
@jouvin jouvin force-pushed the antelope_templates branch from 42dfdb8 to 301652b Compare November 13, 2024 21:47
@jouvin
Copy link
Contributor Author

jouvin commented Nov 13, 2024

Layout change postponed until all panlint / indent errors are fixed.

@jouvin jouvin force-pushed the antelope_templates branch 7 times, most recently from abf115a to 7fd4827 Compare November 14, 2024 09:03
@jouvin
Copy link
Contributor Author

jouvin commented Nov 14, 2024

@jrha I'm trying to fix all the formatting issues, cleanup really needed in these templates! I need to put a few exceptions for lines too long in bind or prefix statements for example but it seems the line is not taken into account. For example features/placement/uwsgi/config.pan:22. Did I make something wrong?

There is also the issue I already mentioned with text in multiline annotations being parsed like in types/openstack/glance.pan but if I remember it is a bug not yet fixed...

@jouvin jouvin force-pushed the antelope_templates branch 6 times, most recently from d9d6032 to 553eebe Compare November 16, 2024 16:01
@jouvin
Copy link
Contributor Author

jouvin commented Nov 16, 2024

@jrha when you are done with the 24.10.0 release, I'd like your suggestions on how to fix the remaining panlint errors. I have the feeling that they are due to panlint flaws... but it may also be a mistake of mine!

  • Line too long for unsplittable lines: I added the following panlint directive which doesn't seem to be taken into accout. Did I miss something?

    # panlint disable=LP006
    
  • 'Trailing /in a parameter value where it is required: how to directpanlint` to ignore it

  • Request to add spaces around - in an annotation: looks like a bug...

@jouvin
Copy link
Contributor Author

jouvin commented Dec 7, 2024

@jrha a reminder that your advice is needed!

Copy link
Member

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line length checks are supposed to to indicate that something isn't being written as clearly as it could be, so I've made some suggestions that I think improve readability.

There are still some lines while will be unavoidably long, particularly the code that drops patch files into the Python path, which in general seems a bit worrying.

@jouvin jouvin force-pushed the antelope_templates branch from 553eebe to 62082c9 Compare December 18, 2024 09:14
@jouvin jouvin marked this pull request as ready for review December 18, 2024 09:14
@jouvin jouvin force-pushed the antelope_templates branch 3 times, most recently from 04aa7bd to 4e8c11a Compare December 18, 2024 10:29
@jouvin
Copy link
Contributor Author

jouvin commented Dec 18, 2024

@jrha thanks for your suggestions, I've been able to fix most of the problems. 2 issues remain but I'm afraid there is no workaround:

  • 'Trailing /in a parameter value where it is required: how to directpanlint` to ignore it
  • A few lines too long in features/magnum/k8s-fragment-fixes.pan prefix lines due to the long file paths involved: is there a panlint directive to exclude them? Or is it possible that panlint ignores this error if the path is entirely enclosed between {} (which means it canot be broken in several pieces).

@jrha
Copy link
Member

jrha commented Dec 18, 2024

If this PR can wait until the various panlint PRs are merged then I think we'll be able to deal with these remaining warnings in a sensible way.

@jouvin
Copy link
Contributor Author

jouvin commented Dec 18, 2024

Yes sure! It can allow to test the the issues are properly solved.

@jrha
Copy link
Member

jrha commented Jan 14, 2026

quattor/pan#278 adds support for suppressing checks on specific lines.

@jrha jrha force-pushed the antelope_templates branch from 4e8c11a to 0106a04 Compare February 11, 2026 11:52
Main changes compared to Yoga templates:

- All API services, except Keystone, handled by uwsgi instead of the
  openstack-xxx-api service (recommended configuration)
- https terminated by a Nginx proxy for all API services, including
  the WSGI apps run into Apache (Keystone, Horizon)
@jrha jrha force-pushed the antelope_templates branch from 0106a04 to 142c8d7 Compare February 11, 2026 11:54
@jrha
Copy link
Member

jrha commented Feb 11, 2026

Rebased on main and updated panlint suppression comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants