-
Notifications
You must be signed in to change notification settings - Fork 9
Templates for OpenStack Antelope version #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
42dfdb8 to
301652b
Compare
|
Layout change postponed until all |
abf115a to
7fd4827
Compare
|
@jrha I'm trying to fix all the formatting issues, cleanup really needed in these templates! I need to put a few exceptions for lines too long in There is also the issue I already mentioned with text in multiline annotations being parsed like in |
d9d6032 to
553eebe
Compare
|
@jrha when you are done with the 24.10.0 release, I'd like your suggestions on how to fix the remaining
|
|
@jrha a reminder that your advice is needed! |
jrha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line length checks are supposed to to indicate that something isn't being written as clearly as it could be, so I've made some suggestions that I think improve readability.
There are still some lines while will be unavoidably long, particularly the code that drops patch files into the Python path, which in general seems a bit worrying.
553eebe to
62082c9
Compare
04aa7bd to
4e8c11a
Compare
|
@jrha thanks for your suggestions, I've been able to fix most of the problems. 2 issues remain but I'm afraid there is no workaround:
|
|
If this PR can wait until the various panlint PRs are merged then I think we'll be able to deal with these remaining warnings in a sensible way. |
|
Yes sure! It can allow to test the the issues are properly solved. |
|
quattor/pan#278 adds support for suppressing checks on specific lines. |
4e8c11a to
0106a04
Compare
Main changes compared to Yoga templates: - All API services, except Keystone, handled by uwsgi instead of the openstack-xxx-api service (recommended configuration) - https terminated by a Nginx proxy for all API services, including the WSGI apps run into Apache (Keystone, Horizon)
0106a04 to
142c8d7
Compare
|
Rebased on |
Templates for Antelope are the first to implement the new repository layout (#62). Fixes #1.