Setup slime contribs if set before loading.#24
Open
mtstickney wants to merge 1 commit intoquicklisp:masterfrom
Open
Setup slime contribs if set before loading.#24mtstickney wants to merge 1 commit intoquicklisp:masterfrom
mtstickney wants to merge 1 commit intoquicklisp:masterfrom
Conversation
In order to allow a customizable set of slime contribs to be setup when loading the helper, check whether slime-contribs has been set, and if so pass that list to slime-setup; otherwise fall back on the default '(slime-fancy) list. slime-setup will use slime-contribs if it is called with no arguments, and the default value for slime-contribs is '(slime-fancy), so this could be done by calling slime-setup with no arguments. However, I'm not certain if that is the case with all relevant versions of slime, and we are already relying on the explicit-argument form, so that's the conservative choice here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to allow a customizable set of slime contribs to be setup
when loading the helper, check whether slime-contribs has been set,
and if so pass that list to slime-setup; otherwise fall back on the
default '(slime-fancy) list.
slime-setup will use slime-contribs if it is called with no arguments,
and the default value for slime-contribs is '(slime-fancy), so this
could be done by calling slime-setup with no arguments. However, I'm
not certain if that is the case with all relevant versions of slime,
and we are already relying on the explicit-argument form, so that's
the conservative choice here.
This should fix #10, if it's acceptable.