Skip to content

fix: Updating saving code for android to be compatible with current Android platform versions #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielDornhardt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Updating saving code for android to be compatible with current Android platform versions #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2feab1c
Updating saving code for android to be compatible with current Androi…
DanielDornhardt Jun 10, 2025
21cb88a
remove outdated permission
DanielDornhardt Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@

<!-- android -->
<platform name="android">
<config-file target="AndroidManifest.xml" parent="/*">
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
</config-file>
<config-file target="res/xml/config.xml" parent="/*">
<feature name="SaveImage">
<param name="android-package" value="com.quiply.cordova.saveimage.SaveImage"/>
Expand Down
52 changes: 33 additions & 19 deletions src/android/SaveImage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
import org.json.JSONException;

import android.Manifest;
import android.content.Context;
import android.content.Intent;
import android.content.pm.PackageManager;
import android.media.MediaScannerConnection;
import android.net.Uri;
import android.os.Environment;
import android.util.Log;
Expand All @@ -32,7 +34,7 @@ public class SaveImage extends CordovaPlugin {
private final String WRITE_EXTERNAL_STORAGE = Manifest.permission.WRITE_EXTERNAL_STORAGE;
private CallbackContext callbackContext;
private String filePath;


@Override
public boolean execute(String action, JSONArray args, CallbackContext callbackContext) throws JSONException {
Expand All @@ -51,27 +53,27 @@ public boolean execute(String action, JSONArray args, CallbackContext callbackCo
* @param callbackContext callback id for optional progress reports
*
* args[0] filePath file path string to image file to be saved to gallery
*/
*/
private void saveImageToGallery(JSONArray args, CallbackContext callback) throws JSONException {
this.filePath = args.getString(0);
this.callbackContext = callback;
Log.d("SaveImage", "SaveImage in filePath: " + filePath);

if (filePath == null || filePath.equals("")) {
callback.error("Missing filePath");
return;
}
if (PermissionHelper.hasPermission(this, WRITE_EXTERNAL_STORAGE)) {
Log.d("SaveImage", "Permissions already granted, or Android version is lower than 6");
performImageSave();
} else {
Log.d("SaveImage", "Requesting permissions for WRITE_EXTERNAL_STORAGE");
PermissionHelper.requestPermission(this, WRITE_PERM_REQUEST_CODE, WRITE_EXTERNAL_STORAGE);
}


/**
* We have removed all permission checks for now. Not sure if it is necessary; but the WRITE_EXTERNAL_STORAGE permission
* has been deprecated and not available since Android Platform SDK 28.
*/

performImageSave();
}


/**
* Save image to device gallery
*/
Expand Down Expand Up @@ -164,12 +166,24 @@ private File copyFile(File srcFile, File dstFolder) {
* @param imageFile The image file to be scanned by the media scanner
*/
private void scanPhoto(File imageFile) {
Intent mediaScanIntent = new Intent(Intent.ACTION_MEDIA_SCANNER_SCAN_FILE);
Uri contentUri = Uri.fromFile(imageFile);
mediaScanIntent.setData(contentUri);
cordova.getActivity().sendBroadcast(mediaScanIntent);
Context context = cordova.getActivity().getApplicationContext();
Log.d("SaveImage", "Attempting to scan file: " + imageFile.getAbsolutePath());
try {
MediaScannerConnection.scanFile(context,
new String[]{imageFile.getAbsolutePath()},
null,
new MediaScannerConnection.OnScanCompletedListener() {
public void onScanCompleted(String path, Uri uri) {
Log.i("SaveImage", "Scanned " + path + ":");
Log.i("SaveImage", "-> uri=" + uri);
}
});
} catch (Exception e) {
Log.e("SaveImage", "Error scanning file: " + imageFile.getAbsolutePath(), e);
callbackContext.error("Error scanning file: " + e.getMessage());
}
}


/**
* Callback from PermissionHelper.requestPermission method
Expand All @@ -182,7 +196,7 @@ public void onRequestPermissionResult(int requestCode, String[] permissions, int
return;
}
}

switch (requestCode) {
case WRITE_PERM_REQUEST_CODE:
Log.d("SaveImage", "User granted the permission for WRITE_EXTERNAL_STORAGE");
Expand Down