ci: Fix comment #165
ci: Fix comment #165
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix a comment in the R-CMD-check workflow file by clarifying when the versions-matrix step runs for pull requests. The original comment had confusing logic with a negation ("does not start with 'cran-'"), and this change aims to simplify it.
Changes:
- Split a single-line comment into two separate bullet points describing when the step runs for pull requests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # - pull requests if the base repo is different from the head repo | ||
| # - pull requests if the branch name starts with "cran-" |
There was a problem hiding this comment.
The comment incorrectly describes the condition logic. The two bullet points under "Only run for:" imply an AND relationship, but the actual code on line 142 uses an OR operator. For pull requests, the step runs when EITHER the base repo is different from the head repo OR the branch name starts with "cran-", not both conditions simultaneously. Consider rephrasing to make the OR relationship clear, such as using a single bullet point that says "pull requests if the base repo is different from the head repo OR if the branch name starts with 'cran-'".
| # - pull requests if the base repo is different from the head repo | |
| # - pull requests if the branch name starts with "cran-" | |
| # - pull requests if the base repo is different from the head repo OR if the branch name starts with "cran-" |
No description provided.