feat: put parentheses inside seealso links #2922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
maelle
commented
Oct 13, 2025
hadley
reviewed
Oct 14, 2025
R/tweak-reference.R
Outdated
| # Fix seealso links | ||
| seealso_links <- xml2::xml_find_all( | ||
| html, | ||
| "//code[a and normalize-space(text()) = '()']" |
Member
There was a problem hiding this comment.
Are you sure you need the normalize-space here? I would think that it would be pretty unusually to have extra whitespace here.
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
hadley
reviewed
Oct 17, 2025
|
|
||
| tweak_anchors(html) | ||
| tweak_link_md(html) | ||
| tweak_link_seealso(html) |
Member
There was a problem hiding this comment.
I think it's slightly better for this to live with the other link tweakers?
| html <- xml2::read_html('<code><a>build_site</a>()</code>') | ||
| tweak_link_seealso(html) | ||
|
|
||
| expect_equal(xpath_contents(html, ".//code"), "<a>build_site()</a>") |
Member
There was a problem hiding this comment.
Main thing here is to use new xpath_contents() helper which makes testing a bit nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.