Skip to content

fix: optimize mint fee distribution and add zero fee check #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crStiv wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: optimize mint fee distribution and add zero fee check #293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9931736
Update QuestFactory.sol
crStiv Jan 17, 2025
e03ccca
Update QuestFactory.sol
crStiv Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions contracts/QuestFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,18 +904,20 @@ contract QuestFactory is Initializable, LegacyStorage, OwnableRoles, IQuestFacto
function processMintFee(address ref_, address mintFeeRecipient_, string memory questId_) private returns (string memory) {
returnChange();
uint256 cachedMintFee = mintFee;
uint256 oneThirdMintfee = cachedMintFee / 3;
require(cachedMintFee > 0, "Zero mint fee");

uint256 oneThirdMintfee = (cachedMintFee * 1000) / 3000; // More precise division
uint256 protocolPayout;
uint256 mintPayout;
uint256 referrerPayout;

if(ref_ == address(0)){
protocolPayout = oneThirdMintfee * 2;
mintPayout = oneThirdMintfee;
mintPayout = cachedMintFee - protocolPayout; // The remainder goes to mintPayout
} else {
protocolPayout = oneThirdMintfee;
mintPayout = oneThirdMintfee;
referrerPayout = oneThirdMintfee;
referrerPayout = cachedMintFee - (protocolPayout + mintPayout); // The remainder goes to referrerPayout
}

protocolFeeRecipient.safeTransferETH(protocolPayout);
Expand Down Expand Up @@ -1019,4 +1021,4 @@ contract QuestFactory is Initializable, LegacyStorage, OwnableRoles, IQuestFacto

// Fallback function to receive ETH when other functions are not available
fallback() external payable {}
}
}