Skip to content

Remove map component 2#427

Open
ShiCheng-Lu wants to merge 2 commits intomasterfrom
remove-map-component-2
Open

Remove map component 2#427
ShiCheng-Lu wants to merge 2 commits intomasterfrom
remove-map-component-2

Conversation

@ShiCheng-Lu
Copy link
Contributor

@ShiCheng-Lu ShiCheng-Lu commented Jan 8, 2026

#417

for some reason the release action didn't trigger. this is a branch from main with cherry picked remove map component

Copilot AI review requested due to automatic review settings January 8, 2026 16:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the map component functionality from the react-native-radar package and changes the version from 3.24.0 to 3.23.6-beta.2 (a version downgrade). The removal includes the map component implementation files, related styles, type definitions, and the maplibre peer dependency.

Key changes:

  • Complete removal of RadarMap component (map.tsx, map.jsx) and related functionality
  • Removal of map-related styles and type definitions
  • Removal of @maplibre/maplibre-react-native peer dependency
  • Version downgrade from 3.24.0 to 3.23.6-beta.2 across all configuration files

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/version.ts Version changed from 3.24.0 to 3.23.6-beta.2
src/ui/styles.js Removed map-related styles (mapContainer, map, mapLogo)
src/ui/map.tsx Deleted entire TypeScript wrapper for RadarMap component
src/ui/map.jsx Deleted entire RadarMap component implementation
src/index.tsx Removed Map export and RadarMapProps type export
src/@types/types.ts Removed RadarMapOptions and RadarMapRegionChangeEvent interfaces
package.json Version downgraded and @maplibre/maplibre-react-native peer dependency removed
package-lock.json Updated to reflect version and dependency changes
ios/RNRadar.mm Version string updated to match new version
example/package-lock.json Updated to reflect version and dependency changes
android/src/oldarch/java/com/radar/RadarModule.java Version string updated to match new version
android/src/newarch/java/com/radar/RadarModule.kt Version string updated to match new version
Files not reviewed (1)
  • example/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"homepage": "https://radar.com",
"license": "Apache-2.0",
"version": "3.24.0",
"version": "3.23.6-beta.2",
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is being changed from '3.24.0' to '3.23.6-beta.2', which is a downgrade. This is problematic because:

  1. Version numbers should generally increase, not decrease, to maintain proper semantic versioning
  2. If users have already installed version 3.24.0, downgrading to 3.23.6-beta.2 could cause issues with package managers
  3. If this is intended to create a beta branch based on an earlier version, the beta version number should be higher than the current stable release (e.g., '3.24.1-beta.1' or '3.25.0-beta.1')

Consider using a higher version number that properly reflects this is a pre-release version of future work, not a regression to an older version.

Suggested change
"version": "3.23.6-beta.2",
"version": "3.24.1-beta.1",

Copilot uses AI. Check for mistakes.
// This file contains the version of the react-native-radar package
// It should be updated to match the version in package.json
export const VERSION = '3.24.0';
export const VERSION = '3.23.6-beta.2';
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is being changed from '3.24.0' to '3.23.6-beta.2', which is a downgrade. This is problematic because:

  1. Version numbers should generally increase, not decrease, to maintain proper semantic versioning
  2. If users have already installed version 3.24.0, downgrading to 3.23.6-beta.2 could cause issues with package managers
  3. If this is intended to create a beta branch based on an earlier version, the beta version number should be higher than the current stable release (e.g., '3.24.1-beta.1' or '3.25.0-beta.1')

Consider using a higher version number that properly reflects this is a pre-release version of future work, not a regression to an older version.

Suggested change
export const VERSION = '3.23.6-beta.2';
export const VERSION = '3.24.1-beta.1';

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants