Open
Conversation
This is already tested in tests/dataset
The FITS writer would not get any data otherwise
This is a temporary measure until we find a fix that allows us to check file creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the entire test framework with unit tests that run faster than the old tests. Also, the new tests cover more edge cases than the previous tests.
Changes
tomlifrom dependencies and test requirements inpyproject.toml, addedpytest-mockas a new test dependencydataset_typeas an toFITSWriterfor consistency with other writer classesexamplesfromruffchecks, nottestspyvisgen.fits.data__getitem__method ofValidBaselineSubsetdataclass to returnValidBaselinesSubsetobject, similar toBaselinesdataclasspyvisgen.simulation.array.Arraynow has updated property namesrelative_posandantenna_pairs. Removedcalc_relative_posmethod that would just get therelative_posproperty