Skip to content

Comments

Add Fiducial Module#34

Draft
tgross03 wants to merge 18 commits intomainfrom
add_skymodels
Draft

Add Fiducial Module#34
tgross03 wants to merge 18 commits intomainfrom
add_skymodels

Conversation

@tgross03
Copy link
Member

  • Added the fiducial module to process and visualize cleaned radio images which are provided as FITS files.

  • Switched CASA table import in src/radiotools/layouts/layouts.py from casatools.table to casacore.table, and updated the table instantiation to include ack=False for compatibility with python-casacore.

  • Added python-casacore>=3.7.1 to the main dependencies in pyproject.toml, and removed the optional CASA dependency group.

  • Replaced the img2jansky function with two new functions, beam2pix and pix2beam, for converting between Jy/beam and Jy/pix units in src/radiotools/utils/utils.py. Updated the corresponding exports in src/radiotools/utils/__init__.py.

  • Removed the src/radiotools/measurements/measurements.py file and its corresponding import/export from src/radiotools/measurements/__init__.py.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1 1 0 0
View the top 1 failed test(s) by shortest run time
tests/test_fiducial.py::tests.test_fiducial
Stack Traces | 0s run time
ImportError while importing test module '.../radiotools/tests/test_fiducial.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../...../radiotools-dev/lib/python3.11.../site-packages/_pytest/python.py:507: in importtestmodule
    mod = import_path(
../../...../radiotools-dev/lib/python3.11.../site-packages/_pytest/pathlib.py:587: in import_path
    importlib.import_module(module_name)
../../...../radiotools-dev/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1147: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:690: in _load_unlocked
    ???
../../...../radiotools-dev/lib/python3.11.../_pytest/assertion/rewrite.py:197: in exec_module
    exec(co, module.__dict__)
tests/test_fiducial.py:1: in <module>
    from radiotools.fiducial import Fiducial
.../radiotools/fiducial/__init__.py:1: in <module>
    from .fiducial import Fiducial
.../radiotools/fiducial/fiducial.py:15: in <module>
    from radio_stats.cuts.dbscan_clean import dbscan_clean
../../...../radiotools-dev/lib/python3.11.../radio_stats/cuts/__init__.py:1: in <module>
    from .dbscan_clean import dbscan_clean
../../...../radiotools-dev/lib/python3.11.../radio_stats/cuts/dbscan_clean.py:3: in <module>
    from sklearn.cluster import DBSCAN
E   ModuleNotFoundError: No module named 'sklearn'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants