Fix for strict mode warning when compiling on Android#4
Open
owaineevans wants to merge 2 commits intorafakob:masterfrom
Open
Fix for strict mode warning when compiling on Android#4owaineevans wants to merge 2 commits intorafakob:masterfrom
owaineevans wants to merge 2 commits intorafakob:masterfrom
Conversation
Attempt to fix a strict mode warning.
Fix silly mistake - I'm still learning how to do this effectivey.
DatL4g
added a commit
to DatL4g/NsdHelper
that referenced
this pull request
Apr 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When strict mode is enabled it complains about a socket not explicitly being closed.
It was easy to fix, (sorry about the double commit).