Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added char functionality. As conveyed to you earlier, it is an add-on to my previous PR, as it makes use of the variable_line() function, which was proposed in the previous PR.
I have checked the merging possibility and it seems compatible with my master branch ( the PR for which has already been sent)
Describe the big picture of your changes why I should accept your pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of Changes
What changes you have done, please checkout the boxes that apply
Summary of Changes
Please describe the changes you have made, be as descriptive as you can
...
If you fixed any bug , Please add screenshots/gifs of the modifications you have done
...
If you have added any new feature please add screenshot of the output, how it has been changed after addition of the new feature
...
Checklist
Please checkout the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask .Join our gitter channel and feel free to ask.
Thank You !