Updated jsdoc to conform to the jsdoc optional parameters#4
Open
JonathanPicques wants to merge 1 commit intorain1017:masterfrom
JonathanPicques:master
Open
Updated jsdoc to conform to the jsdoc optional parameters#4JonathanPicques wants to merge 1 commit intorain1017:masterfrom JonathanPicques:master
JonathanPicques wants to merge 1 commit intorain1017:masterfrom
JonathanPicques:master
Conversation
|
+1 |
|
Hi @JonathanPicques , @Philipp91. Because the author does not respond, the folks at npmjs.org have transferred ownership of async-lock to me. The new repo is at https://www.github.com/rogierschouten. I have incorporated this PR and will do a release soon (which will likely get a major version increase, so you will have to actively upgrade). You can consider this PR as merged. |
rain1017
approved these changes
Mar 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current jsdoc was not valid and IDEs reported the function lock.acquire to require 4 parameters instead of 2 + 2 optionals.