Support for go 1.6 (cgo argument has Go pointer to Go pointer) + stack corruption #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibor Vass <teabee89@gmail.com>
In Go 1.6, arguments passed to C cannot be a Go pointer to memory containing Go pointers. When they do the following panic occurs: panic: runtime error: cgo argument has Go pointer to Go pointer Fix by converting argument to uintptr instead of unsafe.Pointer
Calling sum8 in TestStackArguments fails due to a bug in asm_amd64.S The function sum8 passes 8 arguments, where two of them are pushed on the stack before the function in the shared library is called. After the call instruction in asm_amd64.S returns, the stack must be restored to the previous state before the CPU registers are restored. Since the stack is not restored, invalid values are restored to the CPU registers, leading the incorrect results. Fix by restoring the stack pointer when arguments are passed on the stack.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two commits. One to fix the dreaded panic: runtime error: cgo argument has Go pointer to Go pointer, and one that fixes a bug in asm_amd64.S causing stack corruption.
The PR also includes the commit from tiborvass' PR