[REVIEW] Added missing output buffer in validity tests for groupbys#396
Merged
harrism merged 1 commit intorapidsai:masterfrom Nov 26, 2018
kaatish:bug-ext-op-valid-mask
Merged
[REVIEW] Added missing output buffer in validity tests for groupbys#396harrism merged 1 commit intorapidsai:masterfrom kaatish:bug-ext-op-valid-mask
harrism merged 1 commit intorapidsai:masterfrom
kaatish:bug-ext-op-valid-mask
Conversation
Contributor
|
Possibly redundant with #385 ? |
Contributor
Author
|
It looks like it. However since that PR is a WIP, I would suggest this should be merged as soon as possible because it is affecting open PRs such as #388 |
Collaborator
|
There's other implications with #385 where I'd rather this be merged first and handle that one later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test did not create host side output buffer since no computation was meant to take place. This caused the groupby call to return a GDF_DATASET_EMPTY error since output buffer pointer would be nullptr.