[WIP] libcuml and libcudf groupby integration#37
Open
shaneding wants to merge 7 commits intorapidsai:mainfrom
Open
[WIP] libcuml and libcudf groupby integration#37shaneding wants to merge 7 commits intorapidsai:mainfrom
libcuml and libcudf groupby integration#37shaneding wants to merge 7 commits intorapidsai:mainfrom
Conversation
isVoid
reviewed
Sep 17, 2021
Comment on lines
+17
to
+20
| set(CUDF_TAG branch-21.10) | ||
| CPMFindPackage(NAME cuml | ||
| GIT_REPOSITORY https://github.com/rapidsai/cuml | ||
| GIT_TAG ${CUDF_TAG} |
| int n_cols = 2; | ||
| raft::handle_t handle; | ||
| cudaStream_t stream = rmm::cuda_stream_default.value(); | ||
| CUDA_RT_CALL(cudaStreamCreate(&stream)); |
There was a problem hiding this comment.
Why are we recreating the stream if already using the default rmm stream?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add an example for how
libcumlalgorithms can be ran onlibcudf groupbyresults.cc @isVoid