Python3 conversion. #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of whitespace as I read through the code. Fix some obvious typos and bugs in most likely unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
Thanks for your work on this. It has been fun following along on Hackaday... I am reading through the code to get an understanding of what is going on and took the time to convert it over to Python3....
I would understand if you decline to merge this as the code appears to be very exploratory and in active development. (I saw a few "if False:" blocks that would never get run)
Mostly print statements. String formatting. Lots of PEP8 whitespace added as I read through the code. Fix some obvious typos and bugs in most likely unused code.
Again thank you for your work on this!