Fix #78: Handle spaces and quotes in author argument#111
Open
mariam851 wants to merge 1 commit intorasbt:masterfrom
Open
Fix #78: Handle spaces and quotes in author argument#111mariam851 wants to merge 1 commit intorasbt:masterfrom
mariam851 wants to merge 1 commit intorasbt:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Hi @rasbt,
This PR addresses the UsageError reported in issue #78, where the %watermark magic command fails when an author's name contains spaces (e.g., -a 'Sebastian Raschka').
Changes:
In magic.py: Updated the --author (and -a) argument definition to use nargs='+'. This allows the parser to capture multi-word strings as a list.
Argument Handling: Added logic to .join() the name parts back into a single string before passing it to the core function.
Robustness: Ensured that any surrounding single or double quotes are correctly stripped to prevent formatting issues in the final output.