Open
Conversation
mariam851
force-pushed
the
fix-output-alignment-35
branch
from
5170cc4 to
fd68243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @rasbt,
This PR addresses the formatting issues mentioned in #35. The goal was to make the output cleaner and more consistent across different environments (Jupyter, Terminal, etc.) by removing unnecessary colons and aligning the values.
Changes Implemented:
Output Formatting: Modified _generate_formatted_text to remove colons between keys and values.
Alignment: Updated the layout to ensure a clean, one-space separation between package names and versions, matching the requested format: package 1.0.0.
Test Suite Refactoring: Updated watermark/tests/test_watermark.py to be more robust. The previous tests relied on splitting by :, which caused failures after the formatting change. The new tests now use membership validation (assert any(i in line...)), making the test suite more resilient to future UI changes.