Implement typing overloads for (matrix) multiplication#137
Open
kylebarron wants to merge 3 commits intorasterio:mainfrom
Open
Implement typing overloads for (matrix) multiplication#137kylebarron wants to merge 3 commits intorasterio:mainfrom
kylebarron wants to merge 3 commits intorasterio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when performing multiplication and matrix multiplication, there is poor type hinting. Currently types are resolved as
(the gray text is inlay hints, meaning those are the inferred types that the editor is showing)
With additional errors of:
After this PR, types are inferred cleanly:
Happy to create tests for these if the PR sounds good and you want them. We could use https://github.com/davidfritzsche/pytest-mypy-testing