-
Notifications
You must be signed in to change notification settings - Fork 91
fix: Boolean correction in doc #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
documents/payment.md
Outdated
| "java_enabled": false, | ||
| "javascript_enabled": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
False?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace with True/False
documents/registerEmandate.md
Outdated
| | email | string | Email of the customer | | ||
| | contact | string | Contact number of the customer | | ||
| | fail_existing | string | If a customer with the same details already exists, the request throws an exception by default. Possible value is `0` or `1`| | ||
| | fail_existing | string | If a customer with the same details already exists, the request throws an exception by default. Possible value is `True` or `False`| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible value is True or False.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for highlight, added True/False in ``
documents/registerEmandate.md
Outdated
| | description* | string | A brief description of the payment. | | ||
| | subscription_registration | object | All keys listed [here](https://razorpay.com/docs/api/recurring-payments/emandate/auto-debit/#12-using-a-registration-link) are supported | | ||
| | receipt | string | Your system order reference id. | | ||
| | payment_capture* | boolean | Indicates whether payment status should be changed to `captured` automatically or not. Possible values: true - Payments are captured automatically. false - Payments are not captured automatically.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True
False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
documents/subscription.md
Outdated
| "remaining_count":5, | ||
| "start_at":1496000432, | ||
| "schedule_change_at":"now", | ||
| "customer_notify": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated To True
documents/upi.md
Outdated
| | email | string | Email of the customer | | ||
| | contact | string | Contact number of the customer | | ||
| | fail_existing | string | If a customer with the same details already exists, the request throws an exception by default. Possible value is `0` or `1`|x` | ||
| | fail_existing | string | If a customer with the same details already exists, the request throws an exception by default. Possible value is `True` or `False`|x` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the extra x' should be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
|
pls consider this also: https://github.com/razorpay/razorpay-python/blob/master/documents/paymentLink.md#customize-payment-methods. Here UPI, Netbanking are all boolean values. |
|
here as well, recurring parameter here is boolean: razorpay-python/documents/card.md Line 271 in 283773b
need to make the same changes across payment methods: upi, emandate... |
|
razorpay-python/documents/upi.md Line 107 in 283773b
|
|
https://github.com/razorpay/razorpay-python/blob/283773b4aba0a4a423f1a80966188186c6272c6f/documents/paymentLink.md?plain=1#L780C7-L781C18 - Here email and contact are boolean |
|
razorpay-python/documents/payment.md Line 501 in 283773b
|
|
razorpay-python/documents/items.md Line 145 in 283773b
|
|
razorpay-python/documents/subscription.md Line 270 in 283773b
|
|
|
razorpay-python/documents/card.md Line 584 in 283773b
|
item only support 1/0 (tested) |
vinitajag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Note :- Please follow the below points while attaching test cases document link below:
- If label
Testedis added then test cases document URL is mandatory.- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.