Update node-hid dependency to version 0.7.4#81
Open
Kylir wants to merge 2 commits intordepena:masterfrom
Open
Conversation
Author
|
Sorry, I forgot to mention this is to fix an issue on Linux when you are building node-hid from source. |
Closed
|
This pull would help me |
Contributor
|
@rdepena Could you take a look at this? Currently this is causing the module to break for some users, and the PR only contains a simple version bump. |
| { | ||
| "name": "dualshock-controller", | ||
| "version": "1.1.1", | ||
| "version": "1.1.2", |
Contributor
There was a problem hiding this comment.
I'm pretty sure that this shouldn't be a part of the PR, as usually maintainers bump the version of the module themselves in a separate commit.
Contributor
|
@rdepena Bump |
|
@rdepena Bump :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I understand correctly the version of node-hid included in the project is causing some error with new versions of NodeJS.
This pull request is to update node-hid to the latest (0.7.4).
I also updated the package version number to 1.1.2.