[cryptography] Add test key generator #226
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwielders
requested changes
Sep 8, 2023
|
|
||
| target_link_libraries(cgkeygen | ||
| PRIVATE | ||
| ${NAMESPACE}Cryptography |
Contributor
There was a problem hiding this comment.
I always like consistency :-) and my brain got an error by this construction :-D
Why do we always have ${NAMESPACE}Core::${NAMESPACE}Core and here only once (${NAMESPACE}Cryptography) without the semicolon. I understood from @bramoosterhuis that the first was the preferred way.
If so lets stick to that and always use for components that we as metrological deliver the ${NAMESPACE}Cryptography::${NAMESPACE}Cryptography to avoid my brain errors :-)
Contributor
Author
There was a problem hiding this comment.
Fixed. Now need to educate myself on the difference. :)
sebaszm
force-pushed
the
development/cg-test-keygen
branch
from
2b76393 to
0db71ed
Compare
sebaszm
force-pushed
the
development/cg-test-keygen
branch
from
0db71ed to
a0147d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.