Skip to content

Spork with RVM#1

Open
jcrisp wants to merge 1 commit intordp:masterfrom
jcrisp:master
Open

Spork with RVM#1
jcrisp wants to merge 1 commit intordp:masterfrom
jcrisp:master

Conversation

@jcrisp
Copy link

@jcrisp jcrisp commented Nov 5, 2010

Hi Roger,

Thanks for your fork of Spork for JRuby. It's a great help for start up times!

We just installed it and ran into the strange situation where our Rake launching file under RVM (~/.rvm/gems/jruby-1.5.3@project/bin/rake) kept getting overrwritten with a different, non-functional path to JRuby (ie, the #! stopped working). We found the problem was caused by the lines we've removed in the last commit which re-installed Rake during the bundle install. We are using JRuby 1.5.3, RVM 1.0.18, Rails 3, rspec 2.0.1, bundler 1.0.3.

Just to let you know, and hopefully share the change upstream.

Cheers

@rdp
Copy link
Owner

rdp commented Nov 5, 2010

what version of rails are you using, out of curiosity for this issue: https://github.com/timcharper/spork/issues#issue/60 ?

@timcharper
Copy link

Rake is needed to run extconf, I think rubygems will complain without it?

Does spork install just fine on MRI windows with this patch?

@jcrisp
Copy link
Author

jcrisp commented Nov 10, 2010

Sorry guys for the delay in getting back to you. We are using Rails 3.0.1, JRuby 1.5.3 and we haven't had an issue like https://github.com/timcharper/spork/issues#issue/60. Spork is running fine for us except when we try to launch a ruby process before Spork finishes spinning up. Ie, at this point spork is not ready and ruby processes hang if started:
Macel:web james$ bundle exec spork
Using RSpec
-- Starting to fill pool...
Wait until at least one slave is provided before running tests...
** CTRL+BREAK to stop Spork and kill all ruby slave processes **
Spork is ready and listening on 8989!

After waiting longer for the two loading prefork messages, it is fine to launch rubies.

Macel:web james$ bundle exec spork
Using RSpec
-- Starting to fill pool...
Wait until at least one slave is provided before running tests...
** CTRL+BREAK to stop Spork and kill all ruby slave processes **
Spork is ready and listening on 8989!
Loading Spork.prefork block...
Loading Spork.prefork block...

Cheers,
James

@jcrisp
Copy link
Author

jcrisp commented Nov 10, 2010

To be clearer, perhaps this message could be changed / clearer to avoid people starting rubies too early:

Spork is ready and listening on 8989!

@cayblood
Copy link

Hey guys, I'm just curious to see if this jruby fork is any closer to being pulled into Tim's main spork branch. I'm working on a project with a bunch of developers who prefer windows and could really use it. Anything I can help with?

@rdp
Copy link
Owner

rdp commented May 24, 2011

This should already be fixed in mainline...I...guess it's been so long :)
@cayblood have you tried mainline? Does it work?

@timcharper
Copy link

The lastest commit on rdp's master, "jruby friendlier", was merged in back in September, so I don't know what further would be pending to merge.

@rdp
Copy link
Owner

rdp commented May 24, 2011

actually Tim I don't think the body of my changes were committed as they were superceded by the other fella's branch. But it "should" work in mainline, give it a shot.

@cayblood
Copy link

With 0.8.4 mainline, I was getting a message saying that jruby was unsupported. Didn't research it more closely than that.

@timcharper
Copy link

why are you using 0.8.4 ?

0.9.0rc is the rails 3 compatible release.

On Tue, May 24, 2011 at 11:57 AM, cayblood <
reply@reply.github.com>wrote:

With 0.8.4 mainline, I was getting a message saying that jruby was
unsupported. Didn't research it more closely than that.

Reply to this email directly or view it on GitHub:
#1 (comment)

@cayblood
Copy link

OK, thanks for that. I just ran gem install spork and took what it gave me. I'm not using rails 3. Just a ruby project running on 1.9.2.

@timcharper
Copy link

Ok, there have been many 1.9.2 fixes in the 0.9.0 branch. I don't have the
time to back-port them, so until someone else steps up to the plate, 0.8.x
is a dead branch.

Tim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants