Skip to content

Conversation

@nuintun
Copy link
Contributor

@nuintun nuintun commented Dec 8, 2020

// When not argument provided, we think dev may want to show the scrollbar
if (arg === null || arg === undefined) {
triggerFlash();
return;
}

Summary by CodeRabbit

  • 新功能
    • 现在支持在不传递参数或传递 null 时调用滚动功能,提升了滚动操作的灵活性。

@vercel
Copy link

vercel bot commented Dec 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/virtual-list/et0v166me
✅ Preview: https://virtual-list-git-patch-1.react-component.now.sh

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (f1ddd82) to head (293e563).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          19       19           
  Lines         818      818           
  Branches      194      196    +2     
=======================================
  Hits          799      799           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel
Copy link

vercel bot commented Nov 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtual-list ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 9:18am

@afc163
Copy link
Member

afc163 commented Jun 20, 2025

没发现改动这个的必要。

@afc163 afc163 closed this Jun 20, 2025
@nuintun
Copy link
Contributor Author

nuintun commented Jun 20, 2025

@afc163 现在要手动触发显示滚动条,在 ts 中调用 scrollTo() 会 lint 不过,类型不支持,但是代码支持,必须强制忽略错误!

@afc163 afc163 reopened this Jun 20, 2025
@vercel
Copy link

vercel bot commented Jun 20, 2025

@nuintun is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

@afc163
Copy link
Member

afc163 commented Jun 20, 2025

@nuintun 给个重现看看?

@nuintun
Copy link
Contributor Author

nuintun commented Jun 20, 2025

@afc163

import { memo, useRef } from 'react';
import List, { ListRef } from 'rc-virtual-list';

const data = Array.from({ length: 1000 }).map((_, index) => ({
  id: index
}));

export default memo(function Page() {
  const ref = useRef<ListRef>(null);

  const onClick = () => {
    ref.current?.scrollTo();
  };

  return (
    <>
      <List ref={ref} data={data} height={60} itemHeight={20} itemKey="id">
        {data => <div>{data.id}</div>}
      </List>
      <br />
      <button onClick={onClick}>显示滚动条</button>
    </>
  );
});

image

有需求在某些情况下要触发显示滚动条

@coderabbitai
Copy link

coderabbitai bot commented Jun 20, 2025

Walkthrough

本次变更调整了 ScrollTo 函数的类型定义,使其参数可以为可选,并接受 undefinednull,除了原有的 numberScrollConfig 类型。这使得 scrollTo 函数调用时可以不传参数或显式传递 null

Changes

文件 变更摘要
src/List.tsx 更新 ScrollTo 类型定义,参数支持可选、undefinednull 类型。

Poem

小兔跳跃代码间,
类型拓展更宽广。
scrollTo 可选也可空,
灵活调用无阻挡。
代码如风轻轻扬,
变化之美心中藏。
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/List.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

  • /.eslintrc.js
  • /node_modules/.pnpm/@eslint+eslintrc@2.1.4/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
  • /node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli-engine/cli-engine.js
  • /node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/eslint.js
  • /node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/eslint/index.js
  • /node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/lib/cli.js
  • /node_modules/.pnpm/eslint@8.57.1/node_modules/eslint/bin/eslint.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1405:15)
    at defaultResolveImpl (node:internal/modules/cjs/loader:1061:19)
    at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1066:22)
    at Module._load (node:internal/modules/cjs/loader:1215:37)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
    at Module.require (node:internal/modules/cjs/loader:1491:12)
    at require (node:internal/modules/helpers:135:16)
    at Object. (/.eslintrc.js:1:14)
    at Module._compile (node:internal/modules/cjs/loader:1734:14)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1ddd82 and 293e563.

📒 Files selected for processing (1)
  • src/List.tsx (1 hunks)
🔇 Additional comments (1)
src/List.tsx (1)

40-40: 类型定义增强合理,支持无参数调用

这个类型修改很好地解决了 PR 中提到的问题,允许开发者调用 scrollTo() 而不需要强制忽略 TypeScript 错误。参数设为可选并允许 null 值与实际的实现逻辑一致 - 在 useImperativeHandle 中,isPosScroll 函数会对 undefinednull 返回 false,从而正确地调用内部的 scrollTo 函数。

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@afc163 afc163 changed the title fix: enhance scrollTo ts type type: enhance scrollTo ts type Jun 20, 2025
@afc163 afc163 merged commit 28a6416 into react-component:master Jun 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants