Skip to content

fix: unhandled exception in Fody on netstandard#1578

Merged
ghuntley merged 1 commit intoreactiveui:fodyfrom
energyworldnet:fody_netstandard_fix
Apr 30, 2018
Merged

fix: unhandled exception in Fody on netstandard#1578
ghuntley merged 1 commit intoreactiveui:fodyfrom
energyworldnet:fody_netstandard_fix

Conversation

@gtbuchanan
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
kswoll/ReactiveUI.Fody#26

What is the new behavior (if this is a feature change)?
ReactiveUI.Fody will actually work on netstandard

What might this PR break?
Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
I noticed this fix isn't included in #1503 so I just wanted to make sure it got in there. I included it in my recent netstandard PR to ReactiveUI.Fody.

@gtbuchanan gtbuchanan changed the title Fix unhandled exception on netstandard fix: unhandled exception in Fody on netstandard Mar 12, 2018
@ghuntley
Copy link
Member

Thank-you gtbuchanan!

@ghuntley ghuntley merged commit bf131e4 into reactiveui:fody Apr 30, 2018
@gtbuchanan gtbuchanan deleted the fody_netstandard_fix branch May 3, 2018 20:57
vatsalyagoel pushed a commit that referenced this pull request Jun 10, 2018
* added fody

* Fix unhandled exception on netstandard (#1578)

* Align Fody dependencies to ReactiveUI (#1649)

* added @reactiveui/fody-team

* Finish up ReactiveUI.Fody (#1671)

* Fix package versioning

* Fix ReactiveUI.Fody NuGet package and include tests in build

* Add Fody projects to solution

* Fixed CLI build for Fody

* Added another Reactive Test
glennawatson pushed a commit that referenced this pull request Mar 23, 2019
* added fody

* Fix unhandled exception on netstandard (#1578)

* Align Fody dependencies to ReactiveUI (#1649)

* added @reactiveui/fody-team

* Finish up ReactiveUI.Fody (#1671)

* Fix package versioning

* Fix ReactiveUI.Fody NuGet package and include tests in build

* Add Fody projects to solution

* Fixed CLI build for Fody

* Added another Reactive Test
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants