Finish up ReactiveUI.Fody#1671
Merged
ghuntley merged 3 commits intoreactiveui:fodyfrom Jun 8, 2018
energyworldnet:fody-nuget-fixes
Merged
Finish up ReactiveUI.Fody#1671ghuntley merged 3 commits intoreactiveui:fodyfrom energyworldnet:fody-nuget-fixes
ghuntley merged 3 commits intoreactiveui:fodyfrom
energyworldnet:fody-nuget-fixes
Conversation
Contributor
Author
|
I'm not entirely sure why the ReactiveUI tests failed when I didn't make any changes relating to them. EDIT: Just triple-checked locally and all the tests pass. It must have been from me accidentally selecting |
Member
|
Let's inline this to the fody branch. Ta. |
vatsalyagoel
pushed a commit
that referenced
this pull request
Jun 10, 2018
* added fody * Fix unhandled exception on netstandard (#1578) * Align Fody dependencies to ReactiveUI (#1649) * added @reactiveui/fody-team * Finish up ReactiveUI.Fody (#1671) * Fix package versioning * Fix ReactiveUI.Fody NuGet package and include tests in build * Add Fody projects to solution * Fixed CLI build for Fody * Added another Reactive Test
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
* added fody * Fix unhandled exception on netstandard (#1578) * Align Fody dependencies to ReactiveUI (#1649) * added @reactiveui/fody-team * Finish up ReactiveUI.Fody (#1671) * Fix package versioning * Fix ReactiveUI.Fody NuGet package and include tests in build * Add Fody projects to solution * Fixed CLI build for Fody * Added another Reactive Test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to finish up the ReactiveUI.Fody integration in #1503.
This PR includes the following changes:
I have tested the NuGet package output in a project at my company and it's working great.
I don't think there is anything else remaining. The code ported over from the original project could use some cleanup, but I'd say that shouldn't hold up getting this out to the masses.