Revert https://github.com/reasonml/reason-react/pull/875 #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Both CIs can pass at the same time with different melange versions, that's a bit unfortunate, can we align on using same versions in CI or branch the CI per melange version? @anmonteiro |
Member
|
@davesnx I was thinking we should use the latest (5.0.1) but feel free to use the version you need to unblock you and i'll fix it for the nix build (feel free to merge a PR passing opam and failing nix) |
Member
Author
|
Let me merge #876 and fix the CI in both cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only updating snapshots to run the CI, I could make the test enable_if based on OCAML version or maybe melange version (?) but still easier to keep main working