Skip to content

re #5 - Delete with model inheritance #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daggaz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

re #5 - Delete with model inheritance #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc88c7c
re #5 - Delete with model inheritance
Jun 28, 2016
174c44c
re #5 - Upped version number
daggaz Jul 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions immutablemodel/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# encoding: utf-8
from django.db import models
from django.db import models, router
from django.db.models.deletion import Collector
from django.utils import six


Expand Down Expand Up @@ -194,7 +195,12 @@ def delete(self):
raise CantDeleteImmutableException(
"%s is immutable and cannot be deleted" % self
)
self._deleting_immutable_model = True
collector = Collector(using=router.db_for_write(self.__class__, instance=self))
collector.collect([self], collect_related=False)
collector.sort()
for model, instances in collector.data.items():
for instance in instances:
instance._deleting_immutable_model = True
super(ImmutableModel, self).delete()
delattr(self, '_deleting_immutable_model')

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

setup(
name = 'django-immutablemodel',
version = '0.3.4',
version = '0.3.5',
description="A base class for Django to allow immutable fields on Models",
long_description=README + '\n\n' + NEWS,
classifiers=[
Expand Down