Use debounce instead of throttle to avoid unnecessary re-renders #27
+75
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2024 12:20
…ng the code modifications
added 2 commits
July 16, 2024 12:25
niedzielski
approved these changes
Jul 16, 2024
|
|
||
| /** Throttled changes after updating sources. */ | ||
| #setSrcSideEffects = throttle((save: boolean): void => { | ||
| #setSrcSideEffects = debounce((save: boolean): void => { |
Contributor
There was a problem hiding this comment.
I haven't tried this but trust your judgement 👍 the intent of the original design was to give regular feedback as fast as possible.
Collaborator
Author
There was a problem hiding this comment.
The rollback would be easy in case we hate it, let's give it a try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
💸 TL;DR
Throttle might be not the best strategy for live code editor, since the code is usually not valid during the code modifications, but is valid after they are done
Debounce allows to write code without triggering the re-render (and a potential endless loop or complication error)
🧪 Testing Steps / Validation
Tested locally
I encourage the reviewers to check out the branch, play with the editor and compare experience with the current prod
✅ Checks