Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .ansible-lint
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
profile: production
exclude_paths:
- .ansible/
- .github/
- tests/integration
9 changes: 0 additions & 9 deletions .config/ansible-lint.yml

This file was deleted.

8 changes: 0 additions & 8 deletions .github/workflows/linters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,5 @@ on:
- stable-*

jobs:
ansible-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: run-ansible-lint
uses: ansible/ansible-lint@v25.1.2

tox-linters:
uses: ansible-network/github_actions/.github/workflows/tox-linters.yml@main
20 changes: 20 additions & 0 deletions .github/workflows/sanity-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,38 @@ jobs:
"ansible-version": "milestone",
"python-version": "3.10"
},
{
"ansible-version": "stable-2.20",
"python-version": "3.10"
},
{
"ansible-version": "stable-2.20",
"python-version": "3.11"
},
{
"ansible-version": "stable-2.19",
"python-version": "3.10"
},
{
"ansible-version": "stable-2.19",
"python-version": "3.14"
},
{
"ansible-version": "stable-2.18",
"python-version": "3.10"
},
{
"ansible-version": "stable-2.18",
"python-version": "3.14"
},
{
"ansible-version": "stable-2.17",
"python-version": "3.13"
},
{
"ansible-version": "stable-2.17",
"python-version": "3.14"
},
{
"ansible-version": "stable-2.16"
}
Expand Down
164 changes: 82 additions & 82 deletions changelogs/changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,132 +3,132 @@ releases:
1.0.1:
changes:
minor_changes:
- various playbooks - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various plugins - formating using black (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various roles - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various tests - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various playbooks - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various plugins - formating using black (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various roles - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various tests - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
release_summary: Re-release 1.0.0 with updated README and generated CHNAGELOG,
initial release of the collection
fragments:
- 1_0_1_release.yml
- linting.yml
- 1_0_1_release.yml
- linting.yml
release_date: '2022-11-11'
1.0.2:
changes:
minor_changes:
- various playbooks - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various plugins - formating using black (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various roles - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various tests - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various playbooks - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various plugins - formating using black (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various roles - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
- various tests - minor linting fixes (https://github.com/ansible-collections/cloud.aws_troubleshooting/pull/6).
fragments:
- linting.yml
- linting.yml
release_date: '2022-11-16'
1.0.3:
changes:
bugfixes:
- Fix collection FQCN name issue for role troubleshooting_rds_connectivity (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/13).
- Fix collection FQCN name issue for role troubleshooting_rds_connectivity (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/13).
fragments:
- multiple-renaming.yml
- multiple-renaming.yml
release_date: '2023-03-17'
2.0.0:
changes:
breaking_changes:
- Remove support for ansible-core < 2.14 (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/33).
- roles/aws_setup_credentials - Due to ansible-lint issue, the AWS generated
credentials are now stored into variable ``aws_setup_credentials__output``
instead of ``aws_role_credentials`` (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/24).
- roles/connectivity_troubleshooter_validate - Due to ansible-lint issue, the
next hop information are now stored into variable ``connectivity_troubleshooter_validate__next_hop``
instead of ``next_hop`` (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/24).
- Remove support for ansible-core < 2.14 (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/33).
- roles/aws_setup_credentials - Due to ansible-lint issue, the AWS generated
credentials are now stored into variable ``aws_setup_credentials__output``
instead of ``aws_role_credentials`` (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/24).
- roles/connectivity_troubleshooter_validate - Due to ansible-lint issue, the
next hop information are now stored into variable ``connectivity_troubleshooter_validate__next_hop``
instead of ``next_hop`` (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/24).
bugfixes:
- roles/connectivity_troubleshooter_igw - fix issue wen calling module ``cloud.aws_troubleshooting.eval_src_igw_route``
with wrong value for parameters ``src_subnet_id`` and ``src_network_interface``
(https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/29).
- roles/connectivity_troubleshooter_local - fix issue when using wrong value
for source subnet id, should be ``connectivity_troubleshooter_local__src_subnet_id``
instead of ``src_subnet_id`` and for destination subnet id, should be ``connectivity_troubleshooter_local__dst_subnet_id``
instead of ``dst_subnet_id`` (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/29).
- roles/connectivity_troubleshooter_nat - fix issue when using wrong value for
source subnet id, should be ``connectivity_troubleshooter_nat__src_subnet_id``
instead of ``src_subnet_id`` and add missing steps to gather information about
NAT subnet network ACLs and source ENI (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/29).
- roles/connectivity_troubleshooter_igw - fix issue wen calling module ``cloud.aws_troubleshooting.eval_src_igw_route``
with wrong value for parameters ``src_subnet_id`` and ``src_network_interface``
(https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/29).
- roles/connectivity_troubleshooter_local - fix issue when using wrong value
for source subnet id, should be ``connectivity_troubleshooter_local__src_subnet_id``
instead of ``src_subnet_id`` and for destination subnet id, should be ``connectivity_troubleshooter_local__dst_subnet_id``
instead of ``dst_subnet_id`` (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/29).
- roles/connectivity_troubleshooter_nat - fix issue when using wrong value for
source subnet id, should be ``connectivity_troubleshooter_nat__src_subnet_id``
instead of ``src_subnet_id`` and add missing steps to gather information about
NAT subnet network ACLs and source ENI (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/29).
minor_changes:
- roles/aws_setup_credentials - add ``no_log=true`` when setting credentials
(https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/29).
- roles/aws_setup_credentials - add ``no_log=true`` when setting credentials
(https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/29).
release_summary: This major release drops support for ansible-core versions
lower than 2.14 and Python versions lower than 3.9.
fragments:
- 20230426-update_readme_and_runtime.yml
- 20230907_multiple_fixes.yaml
- 20231018-add-integration-test-for-role-troubleshoot_rds_connectivity.yml
- 20231020-update_docs.yaml
- 20231113-update_supported_versions.yaml
- ansible_lint_sanity_fixes.yml
- automation_hub_update_readme.yaml
- fix_sanity_issues.yaml
- 20230426-update_readme_and_runtime.yml
- 20230907_multiple_fixes.yaml
- 20231018-add-integration-test-for-role-troubleshoot_rds_connectivity.yml
- 20231020-update_docs.yaml
- 20231113-update_supported_versions.yaml
- ansible_lint_sanity_fixes.yml
- automation_hub_update_readme.yaml
- fix_sanity_issues.yaml
release_date: '2023-11-21'
3.0.0:
changes:
breaking_changes:
- Bump minimum version requirement for ansible-core to 2.15 (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/36).
- Bump minimum version requirement for ansible-core to 2.15 (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/36).
minor_changes:
- Bump version of ansible-lint to minimum 24.7.0 (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/36).
- Bump version of ansible-lint to minimum 24.7.0 (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/36).
release_summary: This release removes support for ansible-core < 2.15.
fragments:
- 3.0.0.yml
- 36-bump-ansible-lint-version.yml
- readme_template_update.yml
- 3.0.0.yml
- 36-bump-ansible-lint-version.yml
- readme_template_update.yml
release_date: '2024-07-30'
4.0.0:
changes:
breaking_changes:
- Support for ansible-core < 2.17 has been dropped
- 'setup_aws_credentials - Support for the ``EC2_ACCESS_KEY`` environment variable
has been removed in the latest major release of amazon.aws 10.0.0 and removed
from this role. Please use the ``aws_access_key`` parameter or ``AWS_ACCESS_KEY_ID``
environment variable instead. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)
- Support for ansible-core < 2.17 has been dropped
- 'setup_aws_credentials - Support for the ``EC2_ACCESS_KEY`` environment variable
has been removed in the latest major release of amazon.aws 10.0.0 and removed
from this role. Please use the ``aws_access_key`` parameter or ``AWS_ACCESS_KEY_ID``
environment variable instead. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)

'
- 'setup_aws_credentials - Support for the ``EC2_REGION`` environment variable
has been removed in the latest major release of amazon.aws 10.0.0 and removed
from this role. Please use the ``region`` parameter or ``AWS_REGION`` environment
variable instead. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)
'
- 'setup_aws_credentials - Support for the ``EC2_REGION`` environment variable
has been removed in the latest major release of amazon.aws 10.0.0 and removed
from this role. Please use the ``region`` parameter or ``AWS_REGION`` environment
variable instead. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)

'
- 'setup_aws_credentials - Support for the ``EC2_SECRET_KEY`` environment variable
has been removed in the latest major release of amazon.aws 10.0.0 and removed
from this role.Please use the ``aws_secret_key`` parameter or ``AWS_SECRET_ACCESS_KEY``
environment variable instead. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)
'
- 'setup_aws_credentials - Support for the ``EC2_SECRET_KEY`` environment variable
has been removed in the latest major release of amazon.aws 10.0.0 and removed
from this role.Please use the ``aws_secret_key`` parameter or ``AWS_SECRET_ACCESS_KEY``
environment variable instead. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)

'
- 'setup_aws_credentials - Support for the ``EC2_SECURITY_TOKEN`` and the ``AWS_SECURITY_TOKEN``
environment variable has been removed in the latest major release of amazon.aws
10.0.0 and removed from this role. Please use the ``aws_session_token`` parameter
or ``AWS_SESSION_TOKEN`` environment variable instead. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)
'
- 'setup_aws_credentials - Support for the ``EC2_SECURITY_TOKEN`` and the ``AWS_SECURITY_TOKEN``
environment variable has been removed in the latest major release of amazon.aws
10.0.0 and removed from this role. Please use the ``aws_session_token`` parameter
or ``AWS_SESSION_TOKEN`` environment variable instead. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)

'
- 'setup_aws_credentials - Support for the ``EC2_URL_TOKEN`` environment variable
has been removed in the latest major release of amazon.aws 10.0.0 and removed
from this role. Please use the ``aws_endpoint_url`` parameter or ``AWS_URL``
environment variable instead. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)
'
- 'setup_aws_credentials - Support for the ``EC2_URL_TOKEN`` environment variable
has been removed in the latest major release of amazon.aws 10.0.0 and removed
from this role. Please use the ``aws_endpoint_url`` parameter or ``AWS_URL``
environment variable instead. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)

'
'
bugfixes:
- 'Fix integration tests to work with ansible-core 2.19. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)
- 'Fix integration tests to work with ansible-core 2.19. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)

'
'
minor_changes:
- Bump version of ansible-lint to 25.1.2 (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/42).
- 'documentation - Update playbooks and roles documentation to provide updated
information. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)
- Bump version of ansible-lint to 25.1.2 (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/42).
- 'documentation - Update playbooks and roles documentation to provide updated
information. (https://github.com/redhat-cop/cloud.aws_troubleshooting/pull/45)

'
'
release_summary: Support for certain environment variables has been removed.
The versions of ansible-core, ansible-lint, amazon.aws, and community.aws
have been updated.
fragments:
- 4.0.0-increase_ansible_version.yml
- 4.0.0.yml
- 49-update-ansible-lint.yaml
- fixes.yml
- 4.0.0-increase_ansible_version.yml
- 4.0.0.yml
- 49-update-ansible-lint.yaml
- fixes.yml
release_date: '2025-09-02'
4 changes: 2 additions & 2 deletions galaxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ tags:
- infrastructure
- cluster
dependencies:
amazon.aws: '>=10.0.0'
community.aws: '>=10.0.0'
amazon.aws: '>=10.0.0,<12.0.0-dev0'
community.aws: '>=10.0.0,<12.0.0-dev0'
repository: https://github.com/redhat-cop/cloud.aws_troubleshooting
documentation: ''
homepage: https://github.com/redhat-cop/cloud.aws_troubleshooting
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/eval_src_igw_route.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
private_dns_name: "ip-192-168-0-11.ec2.internal"
private_ip_address: "192.168.0.11"
private_ip_addresses:
- association":
- association:
ip_owner_id: "amazon"
public_dns_name: "ec2-3-93-192-138.compute-1.amazonaws.com"
public_ip: "3.93.192.138"
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/eval_vpc_peering.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
cidr_block: "172.25.0.0/28"
cidr_block_set:
- cidr_block: "172.25.0.0/28"
owner_id": "721066863947"
owner_id: "721066863947"
peering_options:
allow_dns_resolution_from_remote_vpc: false
allow_egress_from_local_classic_link_to_remote_vpc: false
Expand Down
10 changes: 5 additions & 5 deletions plugins/modules/validate_route_tables.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@
owner_id: "00000000000"
private_dns_name_options_on_launch:
enable_resource_name_dns_a_record: false
enable_resource_name_dns_aaaa_record": false
hostname_type": "ip-name"
enable_resource_name_dns_aaaa_record: false
hostname_type: "ip-name"
state: "available"
subnet_arn: "arn:aws:ec2:eu-west-2:721066863947:subnet/subnet-032f1a2598b6318ed"
subnet_id: "subnet-032f1a2598b6318ed"
Expand Down Expand Up @@ -163,8 +163,8 @@
interface_id: null
network_interface_id: null
origin: "CreateRoute"
state": "active"
vpc_id": "vpc-0bee28efef41e1de4"
state: "active"
vpc_id: "vpc-0bee28efef41e1de4"
src_subnets:
- assign_ipv6_address_on_creation: false
availability_zone: "eu-west-2a"
Expand All @@ -181,7 +181,7 @@
owner_id: "00000000000"
private_dns_name_options_on_launch:
enable_resource_name_dns_a_record: false
enable_resource_name_dns_aaaa_record": false
enable_resource_name_dns_aaaa_record: false
hostname_type: "ip-name"
state: "available"
subnet_arn: "arn:aws:ec2:eu-west-2:721066863947:subnet/subnet-0af56e0d353f88cb8"
Expand Down
Loading