Fix: Pass enable_redis_7_config_directives to OSS Cluster server args
#463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes OSS Cluster server initialization by passing the enable_redis_7_config_directives parameter to generate_common_server_args. This ensures Redis 7+ configuration directives like --enable-debug-command are properly applied when running in cluster mode.
Key Changes:
- Added
enable_redis_7_config_directivesparameter to thegenerate_common_server_argscall in cluster initialization - Added a test to verify the parameter is correctly passed through to the generated command
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| redisbench_admin/environments/oss_cluster.py | Modified generate_cluster_redis_server_args to pass enable_redis_7_config_directives parameter to generate_common_server_args, ensuring Redis 7+ config directives are applied in cluster mode |
| tests/test_cluster.py | Added test test_generate_cluster_redis_server_args_passes_redis_7_directive to verify the parameter is correctly passed through |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paulorsousa
changed the title
enable_redis_7_config_directives to OSS Cluster server args
JoanFM
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OSS Cluster server initialization by also passing the
enable_redis_7_config_directivesparameter togenerate_common_server_argsThis ensures
--enable-debug-commandand other Redis 7+ config directives are also properly applied when running cluster mode.closes #462