Allow 0 price (for total loss) and skip transactions without a price#33
Merged
redstreet merged 5 commits intoredstreet:mainfrom Feb 12, 2025
Merged
Allow 0 price (for total loss) and skip transactions without a price#33redstreet merged 5 commits intoredstreet:mainfrom
redstreet merged 5 commits intoredstreet:mainfrom
Conversation
Allow 0 price (for total loss) and skip transactions without a price
Owner
|
Thanks! Could you add unit tests please? |
Add zero or missing price test cases. Renamed test class for gain_loss classifier
Add newline
Remove not needed test
Contributor
Author
|
@redstreet Please let me know if you need anything further for this PR |
Owner
|
Thanks for the ping! Let me take a look tomorrow. |
Contributor
Author
|
@redstreet Hello, any chance we can close this?
Thanks
…On Sun, Jan 19, 2025, 12:37 Red S ***@***.***> wrote:
Thanks for the ping! Let me take a look tomorrow.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCNKWMELRD3OBTNFM4COW32LPWFNAVCNFSM6AAAAABUSABHE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBQHE3TIMZZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Thank you for your patience @scanta2, much appreciated. Sorry I never got back on this. PR looks good, I had just one comment. Actually, I'm happy to merge and then add it myself. Will do in a minute. Sorry again, and thanks for the bugs, the PR, and you patience! |
redstreet
added a commit
that referenced
this pull request
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow 0 price (for total loss) and skip transactions without a price.
Solves #31 and #32.