Add clustal output format as an option#50
Open
uzbit wants to merge 7 commits intorefresh-bio:masterfrom
Open
Conversation
Author
|
I decided to add a flag for sequence type, partially because I just want to move on, but also because ambiguous IUPAC codes can make the automatic determination of sequence type more difficult and not entirely reliable. |
Member
|
Hello @uzbit! |
Author
|
Ping! |
Member
|
Hello! Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preliminary pull request to add clustal output format. Now you can add the flag -output_format <fasta|clustal> and the appropriate output will be given, with default fasta as before.
This is work on closing issue #42 .
One thing that needs to be discussed, is that the output format for clustal is different between DNA/Amino, and so there should be some way of determining this from the input or as another flag maybe? Currently it just assumes AA, which will give misleading output for DNA.