Enhance Help DialogWindow with Keybinds and Scroll Functionality #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgilmer
approved these changes
Mar 15, 2025
Member
kgilmer
left a comment
kgilmer
left a comment
There was a problem hiding this comment.
LGTM. No issues found in local testing.
Contributor
Author
|
@SoumyaRanjanPatnaik i've added Clipboard page here.. Please review it. |
harshaaaaaaaaaa
changed the title
Contributor
|
Hey. To limit the scope of this PR, can you make the clipboard part a seperate PR? |
Contributor
|
Also why did you close this PR previously? |
Contributor
Author
Ah! Sure... Why not! |
Contributor
Author
That time i thought it was merged, and not closed :) |
harshaaaaaaaaaa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added keybinds for navigation and implement scroll functionality in the Help DialogWindow to improve user experience.
ui resizing works without refreshing ilia ui. (i.e. closing and reopening)
Also, fixed cursor positioning bug.