Feat. .Desktop Actions #109

harshaaaaaaaaaa · 2025-06-07T11:23:40Z

Added .desktop actions popover.
Works with :

ctrl+D to hide,
alt+D to show,
alt+D & alt+S to navigate in popover. & few more implementations
ctrl + S for favourite toggle

Screencast_20250607_183046.mov

Added libNotify for notification (Added to Favourite)

TO DO

Add to favourite symbol
App list sort improvement
open in next workspace (works but couldn't open new workspace)

SoumyaRanjanPatnaik · 2025-07-16T04:47:07Z

Can you resolve the conflicts?

SoumyaRanjanPatnaik · 2025-07-16T04:47:37Z

Also please un-draft it if it's ready...

harshaaaaaaaaaa · 2025-07-16T08:54:09Z

Can you resolve the conflicts?

Logs shows, it's docker's issue, as the image is unable to fetch details required.

SoumyaRanjanPatnaik · 2025-07-17T11:25:55Z

Can you resolve the conflicts?

Logs shows, it's docker's issue, as the image is unable to fetch details required.

No like, rebase the branch on top of main. Not talking about the CI failure. Had seen already seen the logs for that.

SoumyaRanjanPatnaik

Preliminary review. Haven't looked at the DesktopAppPage.vala file yet. LMK if you have any queries. Will do a more thorough review later.

src/DialogWindow.vala

src/Application.vala

src/DialogWindow.vala

src/Util.vala

src/clipboard/ClipboardPage.vala

- Fix incorrect UP/DOWN key code constants (65362/65364 swapped) - Improve cursor positioning after paste operations - Enhance keyboard navigation handling for dialog pages - Add proper Alt+D key event delegation to active pages - Improve dialog resizing for both X11 and Wayland - Add get_wm_name() method to SessionController interface

- Add fuzzy_match_score() function for string matching - Add character sequence matching - Include fuzzy_match() helper with configurable threshold - Replace old compare_desktop_apps sorting logic - Improve search accuracy for application names and keywords

- Implement desktop actions popover accessible via Alt+D - Add favorites system with Ctrl+S toggle and star indicators - Support .desktop file actions and generic actions - Include workspace management for next workspace launches - Integrate fuzzy search with favorites prioritization - Add GSettings storage for favorite apps list - Enhance app sorting to prioritize favorites over launch history

- Create standalone HelpPage class implementing DialogPage interface - Add comprehensive keybinding documentation with TreeView - Remove inline help implementation from DialogWindow

SoumyaRanjanPatnaik · 2025-08-26T05:37:24Z

src/DialogWindow.vala

+                case "clipboard":
+                    dialog_pages[0] = new ClipboardPage ();
+                    dialog_pages[0].initialize.begin(settings, arg_map, entry, this, this.wm_name, this.is_wayland);
+                    break;


Remove clipboard page.

SoumyaRanjanPatnaik · 2025-08-26T05:37:39Z

src/DialogWindow.vala

+            dialog_pages[6] = new ClipboardPage ();
+            dialog_pages[6].initialize.begin(settings, arg_map, entry, this, this.wm_name, this.is_wayland);


Remove clipboard page

src/DialogWindow.vala

SoumyaRanjanPatnaik · 2025-08-26T05:38:14Z

src/DialogWindow.vala

         */
        private int create_all_pages(HashTable<string, string ?> arg_map, string focus_page, ref uint start_page) {
-            int page_count = 6;
+            int page_count = 7; // increased for clipboard page


Should be 6 without clipboard page.

SoumyaRanjanPatnaik · 2025-08-26T05:56:19Z

src/DialogWindow.vala

+                return;
+            }
+
+            if (dialog_pages[page_num] is HelpPage) { // On help page


HelpPage doesn't exist at this point.

test/UtilTest.vala

SoumyaRanjanPatnaik · 2025-08-26T07:50:56Z

src/Util.vala

+                if (pos > 0 && (s_lower[pos - 1] == ' ' || s_lower[pos - 1] == '-' || s_lower[pos - 1] == '_')) {
+                    return 85 + int.min(10, 10 * pattern.length / source.length);
+                }
+                // Regular substring match - penalize based on position
+                return 75 + int.min(10, 15 * pattern.length / source.length) - int.min(10, pos / 3);


Refer to my comment on the old commit. See if you can generalize these cases and make the formula more readable. Also is there a specific reason for prioritizing cases with _,- or space?

SoumyaRanjanPatnaik · 2025-08-26T07:53:17Z

src/Util.vala

+        // Check for acronym match (first letters of words)
+        if (check_acronym_match(s_lower, p_lower)) {
+            return 70 + int.min(15, 20 * pattern.length / source.length);
+        }


You can skip this check also. We want to minimize the number of checks we do.

SoumyaRanjanPatnaik · 2025-08-26T07:53:32Z

src/Util.vala

+                    // Bonus for matching at the start
+                    if (j == 0) {
+                        start_bonus += 10;
+                    }
+
+                    // Bonus for matching at word boundaries
+                    if (j > 0 && (s_lower[j - 1] == ' ' || s_lower[j - 1] == '-' || s_lower[j - 1] == '_')) {
+                        word_boundary_bonus += 5;
+                    }
+


Again not sure how this helps.

src/apps/DesktopAppPage.vala

harshaaaaaaaaaa marked this pull request as draft June 7, 2025 11:24

harshaaaaaaaaaa marked this pull request as ready for review July 16, 2025 08:52

SoumyaRanjanPatnaik requested changes Jul 20, 2025

View reviewed changes

harshaaaaaaaaaa force-pushed the desktop-actions branch from f379a1f to 2b8ba1e Compare August 25, 2025 08:35

harshaaaaaaaaaa added 3 commits August 26, 2025 01:19

harshaaaaaaaaaa force-pushed the desktop-actions branch from 822c815 to a7772c3 Compare August 25, 2025 19:55

feat(dialog): implement dedicated help page module

b9ef838

- Create standalone HelpPage class implementing DialogPage interface - Add comprehensive keybinding documentation with TreeView - Remove inline help implementation from DialogWindow

harshaaaaaaaaaa force-pushed the desktop-actions branch from a7772c3 to b9ef838 Compare August 25, 2025 20:07

refractor(DialogWindow)

d6308c8

SoumyaRanjanPatnaik requested changes Aug 26, 2025

View reviewed changes

harshaaaaaaaaaa force-pushed the desktop-actions branch from 9ec7749 to d6308c8 Compare August 29, 2025 20:03

fix(gschema): remove clipboard history key from schema

bb97aac

		dialog_pages[6] = new ClipboardPage ();
		dialog_pages[6].initialize.begin(settings, arg_map, entry, this, this.wm_name, this.is_wayland);

Feat. .Desktop Actions #109

Are you sure you want to change the base?

Feat. .Desktop Actions #109

Uh oh!

Conversation

harshaaaaaaaaaa commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SoumyaRanjanPatnaik commented Jul 16, 2025

Uh oh!

SoumyaRanjanPatnaik commented Jul 16, 2025

Uh oh!

harshaaaaaaaaaa commented Jul 16, 2025

Uh oh!

SoumyaRanjanPatnaik commented Jul 17, 2025

Uh oh!

SoumyaRanjanPatnaik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SoumyaRanjanPatnaik Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

SoumyaRanjanPatnaik Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SoumyaRanjanPatnaik Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

SoumyaRanjanPatnaik Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SoumyaRanjanPatnaik Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

SoumyaRanjanPatnaik Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

SoumyaRanjanPatnaik Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

harshaaaaaaaaaa commented Jun 7, 2025 •

edited

Loading