Default to using release build types #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the default build type to be "release" https://mesonbuild.com/Builtin-options.html#details-for-buildtype This optimizes the build and removes debug symbols. I don't see a speed difference with my timers, but we probably have more work to do there. The build is 65% smaller. I also added docs for how to make a debug build for real debugging. We can also use the `#if !NDBUG` macro (meson adds that for free?) for any code we want to gate on a debug build.
Member
65!? OMG |
Member
|
That's an amazing find, well done @solarkennedy ! |
Member
|
Is it this? Doesn't seem right if "size" is bytes.. $ readelf -S /usr/bin/ilia
...
Section Headers:
[Nr] Name Type Address Offset
Size EntSize Flags Link Info Align
[27] .gnu_debuglink PROGBITS 0000000000000000 00040018
0000000000000034 0000000000000000 0 0 4 |
Contributor
Author
|
This is what i have: |
Member
|
Got it, thanks! The repo on the computer I'm typing on has an older copy of the git repo from before your update: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default build type to be "release" https://mesonbuild.com/Builtin-options.html#details-for-buildtype
This optimizes the build and removes debug symbols.
I don't see a speed difference with my timers, but we probably have more work to do there. The build is 65% smaller.
I also added docs for how to make a debug build for real debugging. We can also use the
#if !NDBUGmacro (meson adds that for free?) for any code we want to gate on a debug build.