Introduce pipelines to build uat instances#423
Conversation
Review Summary by QodoAdd Tekton pipelines for UAT instance builds
WalkthroughsDescription• Add Tekton pipeline configurations for UAT instance builds • Support pull request and push events on uat-instance branch • Configure separate pipelines for sync2jira and sync-page-uat components • Set up container image building with expiration and versioning Diagramflowchart LR
A["uat-instance branch"] -->|"pull_request event"| B["sync2jira-uat-pull-request"]
A -->|"push event"| C["sync2jira-uat-push"]
A -->|"pull_request event"| D["sync2jira-sync-page-uat-pull-request"]
A -->|"push event"| E["sync2jira-sync-page-uat-push"]
B --> F["build-pipeline"]
C --> F
D --> F
E --> F
F --> G["Container images on Quay.io"]
File Changes1. .tekton/sync2jira-uat-pull-request.yaml
|
|
/retest |
Code Review by Qodo
1. Missing sync-page-uat Dockerfile
|
| - name: dockerfile | ||
| value: Dockerfile.sync-page-uat |
There was a problem hiding this comment.
1. Missing sync-page-uat dockerfile 🐞 Bug ✓ Correctness
The new UAT sync-page PipelineRuns reference Dockerfile.sync-page-uat, but the repository only contains Dockerfile.sync-page. The build-pipeline passes this param to the build task as the Dockerfile path, so UAT sync-page builds will fail at runtime when the file can’t be found.
Agent Prompt
### Issue description
The UAT sync-page Tekton PipelineRuns pass `Dockerfile.sync-page-uat` into the shared `build-pipeline`, but there is no such Dockerfile in the repository. This will cause the build task to fail when it tries to use the specified Dockerfile.
### Issue Context
The `build-pipeline` uses `$(params.dockerfile)` as the Dockerfile path for the build task.
### Fix Focus Areas
- .tekton/sync2jira-sync-page-uat-pull-request.yaml[25-31]
- .tekton/sync2jira-sync-page-uat-push.yaml[24-29]
### Suggested fix
Choose one:
1) Add `Dockerfile.sync-page-uat` (likely based on `Dockerfile.sync-page`, adjusting labels/CMD/build args as needed for UAT).
2) If UAT does not require a separate Dockerfile, change both UAT sync-page PipelineRuns to `Dockerfile.sync-page`.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
0c8f5d1 to
728b748
Compare
No description provided.