Skip to content

Do not setup pre-commit when no-lint-gen=true #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thekondor merged 1 commit into from
Dec 2, 2025
Merged

Do not setup pre-commit when no-lint-gen=true #149

thekondor merged 1 commit into from
Dec 2, 2025

Conversation

@thekondor
Copy link
Contributor

@thekondor thekondor commented Dec 2, 2025 •
edited
Loading

pre-commit is required when there is a make gen executed. Otherwise, there is no need to install it, it is not used anyway.

image

Ticket: https://remerge.atlassian.net/browse/CORE-1489

@thekondor thekondor requested a review from a team as a code owner December 2, 2025 10:22
@thekondor thekondor self-assigned this Dec 2, 2025
@remerge-hal
Copy link

remerge-hal commented Dec 2, 2025

This comment ensures that the correct Slack channel is notified after the team/project label CORE has been added to this pull request.

See this comment for details.

@thekondor thekondor merged commit 775901a into main Dec 2, 2025
3 checks passed
@thekondor thekondor deleted the CORE-1489__skip-precommit-install-no-lint-gen branch December 2, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tundeaoni tundeaoni tundeaoni approved these changes

Assignees

@thekondor thekondor

Labels

CORE

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thekondor @remerge-hal @tundeaoni