Class 1 Datatypes #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneemeyer
suggested changes
Jul 19, 2017
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
Renata, nice job, just a couple of fixes to make. Make sure you switch back to the class1datatypes to fix, and push. The pull request will update automatically. Go back to the PR on github, once all the comments are addressed, merge and delete the branch.
01week/javascripting/datatypes.js
Outdated
|
|
||
| //Current Date & Time | ||
| function returnDate() { | ||
| let now = new Date(); |
There was a problem hiding this comment.
let is redundant. can be simplified to be one line return new Date();
01week/javascripting/datatypes.js
Outdated
|
|
||
| //Convert # to String | ||
| function numToString(x) { | ||
| return x.toString(); |
01week/javascripting/datatypes.js
Outdated
| //Convert a String to # | ||
| function stringToNum(x) { | ||
| let a = parseInt(x); | ||
| console.log(a); |
01week/javascripting/datatypes.js
Outdated
|
|
||
| //One of two things are true | ||
| function theTruth() { | ||
| if (9 > 8 && 9 > 10) { |
There was a problem hiding this comment.
Refactor to evaluate if two arguments are true (like in class)
01week/javascripting/datatypes.js
Outdated
| //Both not true | ||
| function theTruth() { | ||
| if (9 === 8 && 8 === 7) { | ||
| console.log("Numbers never lie!"); |
There was a problem hiding this comment.
Refactor to evaluate if two arguments are not true (like in class)
added 2 commits
August 6, 2017 22:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3